Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update starter workflows to use the latest artifact actions #2726

Merged
merged 2 commits into from
Jan 21, 2025
Merged

Update starter workflows to use the latest artifact actions #2726

merged 2 commits into from
Jan 21, 2025

Conversation

joshmgross
Copy link
Member

@joshmgross joshmgross commented Jan 16, 2025 •
edited
Loading

https://github.blog/changelog/2024-04-16-deprecation-notice-v3-of-the-artifact-actions/

The v3 artifact actions are being deprecated, we should use v4 instead.

Note:

  1. I have not tested each workflow individually, but the usage seems relatively straightforward so I do not think any of the breaking changes should affect this workflows
  2. The v4 artifact actions are not supported on GHES - 72cd01c should ensure the GHES version of these workflows remains v3

@joshmgross joshmgross requested review from a team as code owners January 16, 2025 21:00
@github-actions github-actions bot added the code-scanning Related to workflows that show on the Code Scanning setup page label Jan 16, 2025
@joshmgross joshmgross requested a review from felipesu19 January 17, 2025 20:40
@joshmgross joshmgross force-pushed the joshmgross/update-artifact-actions branch from 72cd01c to dac07c6 Compare January 17, 2025 20:42
@janbrasna
Copy link

What can break:

  1. iteratively adding to the files from a matrix run (now a different strategy to merge any outputs after collecting them from individual matrix runs is necessary)
  2. hidden (dot) files are not included by default

@joshmgross
Copy link
Member Author

2. hidden (dot) files are not included by default

That change is also in v3, so if that broke these workflows then they're already broken.

@joshmgross joshmgross merged commit 1e05f3c into main Jan 21, 2025
6 checks passed
@joshmgross joshmgross deleted the joshmgross/update-artifact-actions branch January 21, 2025 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@konradpabjan konradpabjan konradpabjan approved these changes

@leoiskir leoiskir leoiskir approved these changes

@felipesu19 felipesu19 Awaiting requested review from felipesu19

Assignees
No one assigned
Labels
code-scanning Related to workflows that show on the Code Scanning setup page
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@joshmgross @janbrasna @konradpabjan @felipesu19 @leoiskir